Fix regression WHERE (not) in (4.2.0)

AlaSQL / alasql

AlaSQL.js - JavaScript SQL database for browser and Node.js. Handles both traditional relational tables and nested JSON data (NoSQL). Export, store, and import data from localStorage, IndexedDB, or Excel.

http://alasql.org

MIT License

7.02k stars 655 forks source link

Fix regression WHERE (not) in (4.2.0) #1830

Closed paulrutter closed 11 months ago

paulrutter commented 11 months ago

Fix for https://github.com/AlaSQL/alasql/issues/1829.

Fix regression when using IN / NOT IN
Using refs didn't work anymore
Dropped set cache, as it's not really needed unless the same queries are performed often
Added unit test to guard behavior

paulrutter commented 11 months ago

@mathiasrw Some regression introduced in 4.2.0, this PR fixes it. I removed the Set cache as i couldn't get it to work with passing references. It would still be beneficial when running the same query with lots of IN values against different data though, but we might add that back in later.

See the new unit test.

mathiasrw commented 11 months ago

Thank you so much for acting on this rapidly.

mathiasrw commented 11 months ago

Released as part of 4.2.1