search

AlabamaASRL / asset_asrl

https://alabamaasrl.github.io/asset_asrl/
Apache License 2.0
29 stars 6 forks source link

[Feature Request] Dockerfile Enhancements #9

Closed jasonmeverett closed 1 year ago

jasonmeverett commented 1 year ago

Putting this here, unless ASRL has a different issue tracking system you want to use.

Dockerfile should be enhanced for the following:

Multiple Architectures

Currently Dockerfile only supports linux/amd64 architectures. Limiting factor is a Miniconda installation specifically for x64 architecture: 

RUN wget https://repo.anaconda.com/miniconda/Miniconda3-py39_22.11.1-1-Linux-x86_64.sh \
  && bash Miniconda3-py39_22.11.1-1-Linux-x86_64.sh -b -p /opt/miniconda3 \
  && ...

Some research is required to see if Dockerfile can be created for different architectures.

Hard-coded CPU Count

In ASSET build step, CPU count is currently hard-coded:

  && ...
  && cd build/ \
  && cmake -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=true .. \
  && cmake --build . -j4 \
  && cd / \
  && ...

ASRL Docker Hub repo

ASRL should make a Docker Hub account/repository and push Docker images to that account.

jasonmeverett commented 1 year ago

Will break this down into relevant smaller tasks.