AlacrisIO / meta

Internal management of Legicash/Legilogic/Alacris
0 stars 0 forks source link

ABI selection from `solc` output is subtly broken #169

Open mattaudesse opened 4 years ago

mattaudesse commented 4 years ago

Right now it's possible to wind up with const ABI = []; in the compiler's JavaScript output due to the way we're plucking ABIs from solc's JSON.

Since queries against the deserialized JSON don't guarantee ordered results, and since there are multiple keys with the same name, once in a while we accidentally pick the wrong one out of the heap.

The relevant code is here.