This is occurring in a test case with pretty old data with no NC and no IPC samples. I’m just randomly calling some samples NC and IPC and getting failures. That’s the reason for the changes. In practice I don’t expect issues.
Dwight Kuo
[Text Description automatically generated]
47071 Bayside Pkwy, Fremont, CA 94538
From: Joanne Beer @.>
Reply-To: Alamar-Biosciences/NULISAseqR @.>
Date: Tuesday, May 9, 2023 at 13:47
To: Alamar-Biosciences/NULISAseqR @.>
Cc: Dwight Kuo @.>, Author @.***>
Subject: Re: [Alamar-Biosciences/NULISAseqR] changes to skeleton.Rmd calculations for robustness (PR #65)
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
@jcbeer approved this pull request.
this looks fine, but do you anticipate having missing values for some reason? as it is now i can't see how they would occur (since we are replacing any missing with zeros)
jcbeer
commented
1 year ago
This is occurring in a test case with pretty old data with no NC and no IPC samples. I’m just randomly calling some samples NC and IPC and getting failures. That’s the reason for the changes. In practice I don’t expect issues.
Dwight Kuo [Text Description automatically generated] 47071 Bayside Pkwy, Fremont, CA 94538
From: Joanne Beer @.> Reply-To: Alamar-Biosciences/NULISAseqR @.> Date: Tuesday, May 9, 2023 at 13:47 To: Alamar-Biosciences/NULISAseqR @.> Cc: Dwight Kuo @.>, Author @.***> Subject: Re: [Alamar-Biosciences/NULISAseqR] changes to skeleton.Rmd calculations for robustness (PR #65)
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
@jcbeer approved this pull request.
this looks fine, but do you anticipate having missing values for some reason? as it is now i can't see how they would occur (since we are replacing any missing with zeros)
— Reply to this email directly, view it on GitHubhttps://github.com/Alamar-Biosciences/NULISAseqR/pull/65#pullrequestreview-1419432105, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFMZKTYIAGOWNLWGSPLGPHDXFKUOVANCNFSM6AAAAAAX3YKEAU. You are receiving this because you authored the thread.Message ID: @.***>