Use accept header that is sorted for default header.

Alamofire / AlamofireImage

AlamofireImage is an image component library for Alamofire

MIT License

3.99k stars 523 forks source link

Use accept header that is sorted for default header. #429

Closed jksy closed 4 years ago

jksy commented 4 years ago

Goals :soccer:

I'm building an image storage SaaS and using a CDN. One of my clients is using this library and the AcceptHeader changes every time. So the CDN cache doesn't work effectively.

Implementation Details :construction:

I change the order of the Accept Header to sort before return it.

Testing Details :mag:

I've modified it to test the sorted accept header. Please let me know what kind of test I should do if needed other cases.

jksy commented 4 years ago

@jshier @cnoon Hi, One test is failing, but I think it has something to do with the matter below. https://github.com/Alamofire/AlamofireImage/pull/415

I'd like to merge to master with this PR, but how do I do it?