Alamofire / AlamofireImage

AlamofireImage is an image component library for Alamofire
MIT License
3.99k stars 523 forks source link

Basic SwiftUI support #446

Closed alexdremov closed 1 year ago

alexdremov commented 3 years ago

Issue Link :link:

https://github.com/Alamofire/AlamofireImage/issues/430

Goals :soccer:

Implementation Details :construction:

Looking forward to your comments and advices! Really wanted to make this beautiful framework to support SwiftUI

jshier commented 3 years ago

Thanks for the PR! However, there are a number of improvements that need to be made before we can accept it.

First, it should offer an API surface as similar as possible to the newly added AsyncImage. Ideally users would just need to change the type of the view to migrate between the types.

Second, it needs to include API that allows users to progressively customize the underlying image loading behavior. This would start with simply loading a URL like AsyncImage to being able to take a full ImageDownloader instance.

Third, it should not use AnyView but instead embrace generics to allow the placeholder to be fully defined by a ViewBuilder.

alexdremov commented 3 years ago

Thanks for the reply!

I'll try to implement what you requested and will notify when it's ready

rr-james-hickman commented 2 years ago

@AlexRoar any update on this? Hoping for some native SwiftUI support so we can utilize this library in our app.

alexdremov commented 2 years ago

@AlexRoar any update on this? Hoping for some native SwiftUI support so we can utilize this library in our app.

No, have not worked on that one. Found side library for lazy images