search

AlanLoh / nenupy

NenuFAR python package
MIT License
10 stars 6 forks source link

Commit breaks example #64

Closed CedricDViou closed 12 months ago

CedricDViou commented 1 year ago

Commit c4043b8 breaks example https://nenupy.readthedocs.io/en/latest/simu/beam_simulation.html#mini-array-response.

ValueError: shape mismatch: value array of shape (3, 12, 196608) could not be broadcast to indexing result of shape (12, 3, 196608)

class _AntennaGain getter doesn't return the right shape anymore.

AlanLoh commented 1 year ago

Thanks Cedric, I did struggle a bit with that, Emilie had other issues as well. I've added several tests to hopefully cover all possibilities.

CedricDViou commented 1 year ago

Thanks a lot for looking at this.