search

AlanOC91 / YGOPRODeck

Yu-Gi-Oh! Card Database and Deck Share Site
80 stars 4 forks source link

Card Collection #128

Closed AlanOC91 closed 2 years ago

AlanOC91 commented 4 years ago

Look into adding the functionality of card collection tracking.

This would allow users to create a custom list of cards they own in their collection.

Minimum required info:

We'll also need a login system to keep the information stored. This is the bigger issue. The database db.ygoprodeck.com currently uses no login system. Ygoprodeck uses a login system and I could try cross sync them but this is messy. Will need to investigate. I already have an offline login system created for it but not implement or tested fully yet.

AlanOC91 commented 3 years ago

Would it be possible to add a way to select edition while adding a card? Sometimes its confusing when adding a card that has the same set code (that is already in your collection) but of a different edition.

Ex. SDJ-001 1st Edition vs Unlimited

I had planned on adding an general "Edition" drop-down similar to the one we currently have for "Condition". However this caused problems when attempting to add cards with editions that do not exist. I can try revisit and see if I can come up with a cleaner solution.

At the moment if you need to do this, change the general condition tab at the bottom of your collection to something else to add the card.

AlanOC91 commented 3 years ago
Cubikon commented 3 years ago 
* Added Sort by Card Set Name.

* Added Undo Sort button to go back to default sorting (replaced Sort by Name).

Can you add a Sort by Set Number after the Set Name Sort? E.g LOB and then from Card 1 to 125 and Not Alphabetical

IceshadeComets commented 3 years ago

Would it be possible to change the amount of cards a Random Deck would generate? Because on default it seems it uses a set ratio and always gives 60 cards and 15 extra deck cards.

AexDEye9 commented 3 years ago

Duelist League 1 European Promos do not exist within the card collection Time Wizard (DL1-E001) Barrel Dragon (DL1-E002) if i find more, i'll edit this comment. image

New Missing Card Collection entries: Wattkid (TP1-016) Kuwagata α (TP1-030) (this card also has no pricing, i hate that alpha symbol)

Seiyaryu (SDD-E001) Acid Trap Hole (SDD-E002) Salamandra (SDD-E003)

Gradius' Option (LOD-060) (thanks to the damn quotemark)

Exchange (TSC-E001) Graceful Dice (TSC-E002) Skull Dice (TSC-E003)

AexDEye9 commented 3 years ago

When adding cards via the top searchbar, the total number of cards between pages (in brackets) adds 1 onto the end of the number, instead of adding 1 to the number, hillarious but a legit bug! image

AexDEye9 commented 3 years ago

Followup on Kuwagata α: Pressing "Save Card" on it's card page leads to null. image

AlanOC91 commented 3 years ago

When adding cards via the top searchbar, the total number of cards between pages (in brackets) adds 1 onto the end of the number, instead of adding 1 to the number, hillarious but a legit bug! image

This is fixed now!

Will look into missing cards. This seems to be a re-occuring issues due to the fact we are linking in with TCGplayer Data and they are sometimes excluding cards/using weird naming schemes causing table joins to fail.

Will also look into Kuwagata. I also hate that alpha symbol!

AexDEye9 commented 3 years ago

When adding cards via the top searchbar, the total number of cards between pages (in brackets) adds 1 onto the end of the number, instead of adding 1 to the number, hillarious but a legit bug! image

This is fixed now!

Will look into missing cards. This seems to be a re-occuring issues due to the fact we are linking in with TCGplayer Data and they are sometimes excluding cards/using weird naming schemes causing table joins to fail.

Will also look into Kuwagata. I also hate that alpha symbol!

Thanks for the help! i do wish some of yugioh's historical data was kept static and not fed off of some API... i only typed out all the missing cards currently available on my discord's progression series.

zephyros-dev commented 1 year ago 
* Added Sort by Card Set Name.

* Added Undo Sort button to go back to default sorting (replaced Sort by Name).

Can you add a Sort by Set Number after the Set Name Sort? E.g LOB and then from Card 1 to 125 and Not Alphabetical

Would love to have this included also since I sorted my cards using Set Code