AlanOC91 / YGOPRODeck

Yu-Gi-Oh! Card Database and Deck Share Site
80 stars 4 forks source link

enhanced language support #196

Open BlackRose01 opened 4 years ago

BlackRose01 commented 4 years ago

Please provide multiple language support for the endpoints Archetypes and Card Sets. Also provide translations for the other fields in the card information endpoints, please.

KR, BlackRose01

AlanOC91 commented 4 years ago

I can look into translating the other fields returned but archetype and card set might be a little difficult. I'll have a look over the coming weeks to see what I can do!

BlackRose01 commented 4 years ago

Thank you

necrodraco commented 3 years ago

Don't know if this will still be looked into (1 year old now) but the language support for "Pendulum Cards" isn't really accurate. English Pendulum Cards has following Desc (example: Odd-Eyes Arc Pendulum Dragon): "desc": "[ Pendulum Effect ]\r\nIf an \"Odd-Eyes\" card(s) you control is destroyed by battle or card effect: You can Special Summon 1 \"Odd-Eyes\" monster from your hand, Deck, or GY. You can only use this effect of \"Odd-Eyes Arc Pendulum Dragon\" once per turn.\r\n----------------------------------------\r\n[ Flavor Text ]\r\nMade from miracles, this valiant and beautiful dragon has gleaming eyes that reflect an arc drawn in the sky."

But the Ones in other Languages (only tested german) don't contain the pendulum Effect, only Monster Eff/Flavor Text: "desc": "''Dieser beherzte und sch\u00f6ne Drache besteht aus Wundern und hat gl\u00e4nzende Augen, die einen Bogen reflektieren, der an den Himmel gemalt wurde.''\n"

On the way: wouldn't it make sense to seperate the desc field into additional pend_desc for pendulum cards?