search

AlanOC91 / YGOPRODeck

Yu-Gi-Oh! Card Database and Deck Share Site
81 stars 4 forks source link

Duplicate and missing sets in the cardset endpoint #257

Closed Cubikon closed 2 years ago

Cubikon commented 3 years ago

In the cardinfo endpoint there is only a set name Yugi & Kaiba Collector Box and in the cardsets endpoint there is Yugi & Kaiba Collector Box, Yugi Collector Box and Kaiba Colelctor Box. I think you should remove the combined name and only keep the single names in the cardset endpoint and cardinfo endpoint, because the 2 cards in this sets have a different set code.

Missing sets in the cardsets endpoint:

Wrong set name in the cardinfo endpoint: -WB01-EN001 and 002 super rare ( the "cards" in the set name needs to be "Cards")

set in cardsets endpoint but there is none card in cardinfo endpoint with this set:

I hope this can help

AlanOC91 commented 3 years ago

In the cardinfo endpoint there is only a set name Yugi & Kaiba Collector Box and in the cardsets endpoint there is Yugi & Kaiba Collector Box, Yugi Collector Box and Kaiba Colelctor Box. I think you should remove the combined name and only keep the single names in the cardset endpoint and cardinfo endpoint, because the 2 cards in this sets have a different set code.

I see the issue alright, I'll look into this.

Missing sets in the cardsets endpoint

These should now be fixed!

-WB01-EN001 and 002 super rare ( the "cards" in the set name needs to be "Cards")

Fixed!

MP20-EN041,MP20-EN24...

Fixed!

Yu-Gi-Oh! 5D's Tag Force 5....

Fixed!

set in cardsets endpoint but there is none card in cardinfo endpoint with this set:

Hmmm I checked these and they seem to be working?

https://db.ygoprodeck.com/api/v7/cardsetsinfo.php?setcode=YDPR-ENS01

Cubikon commented 3 years ago

Hmmm I checked these and they seem to be working?

https://db.ygoprodeck.com/api/v7/cardsetsinfo.php?setcode=YDPR-ENS01

Oh you are right. I overlooked them. i had a filter with only tcg cards.

The set name of the cards PCY-004 and PCY-005 are wrong. They were only in the Yu-Gi-Oh! Power of Chaos: Yugi the Destiny Limited Collector's Edition and not in the Yu-Gi-Oh! Power of Chaos: Yugi the Destiny promotional cards.

I also found over 500 cards that do not have a cardsets array. I think they are all cards that are ocg-only.

missing_cardset_array.txt

blackedge0 commented 3 years ago

Hmmm I checked these and they seem to be working? https://db.ygoprodeck.com/api/v7/cardsetsinfo.php?setcode=YDPR-ENS01

Oh you are right. I overlooked them. i had a filter with only tcg cards.

The set name of the cards PCY-004 and PCY-005 are wrong. They were only in the Yu-Gi-Oh! Power of Chaos: Yugi the Destiny Limited Collector's Edition and not in the Yu-Gi-Oh! Power of Chaos: Yugi the Destiny promotional cards.

I also found over 500 cards that do not have a cardsets array. I think they are all cards that are ocg-only.

missing_cardset_array.txt

For those 500+ missing cards, I also scrubbed through them all and they are either OCG exclusive (such as 30,000-Year White Turtle), not yet released in the TCG but added to the system preemptively (ZW - Dragonic Halberd) or are simply not in the system yet (like basically any existing TCG token card). I know Alan mentioned something about the tokens in an earlier issue but I agree the missing card sets does throw the endpoint system off a bit

AlanOC91 commented 3 years ago

Yeah those are OCG cards primarily. I'll look into potentially filtering them out and adding an optional filter to query them.