AlanOC91 / YGOPRODeck

Yu-Gi-Oh! Card Database and Deck Share Site
81 stars 4 forks source link

Small corrections for core sets #332

Open Larikk opened 3 years ago

Larikk commented 3 years ago

I compared the API results of the core sets with the offical database from Konami and found a couple issues:

I personally do not care about the last two points but I figured letting you know does not hurt.

The missing attribute in the following json lists cards that appear in the Konami DB but not in the API. The excess attributes means the opposite. Cards which are named differently in both sources appear in both attributes.

{
    "Ancient Prophecy": {
        "missing": {
            "Rare": [
                "Falchion\u03b2"
            ]
        },
        "excess": {
            "Rare": [
                "Falchion Beta"
            ]
        }
    },
    "Burst Of Destiny": {
        "_comments": [
            "Eglen: https://db.ygoprodeck.com/api/v7/cardinfo.php?id=54334420 is missing the set and name is misspelled",
            "Bravedrive: https://db.ygoprodeck.com/api/v7/cardinfo.php?id=78161361 is missing the set and name is misspelled",
            "Danger! https://db.ygoprodeck.com/api/v7/cardinfo.php?id=23213239 is missing the set and name is misspelled"
        ],
        "missing": {
            "Common": [
                "Bravedrive",
                "Danger! Disturbance! Disorder!"
            ],
            "Super Rare": [
                "Floowandereeze & Eglen"
            ]
        },
        "excess": {}
    },
    "Crimson Crisis": {
        "missing": {
            "Common": [
                "Summon Reactor \u30fbSK",
                "Trap Reactor \u30fbY FI",
                "Spell Reactor \u30fbRE"
            ]
        },
        "excess": {
            "Common": [
                "Spell Reactor RE",
                "Summon Reactor SK",
                "Trap Reactor Y FI"
            ]
        }
    },
    "Crossroads Of Chaos": {
        "_comment": "\u00dc is Ü",
        "missing": {
            "Secret Rare": [
                "Machine Lord \u00dcr"
            ]
        },
        "excess": {
            "Secret Rare": [
                "Machine Lord Ur"
            ]
        }
    },
    "Generation Force": {
        "missing": {
            "Common": [
                "Damage Vaccine \u03a9 MAX"
            ]
        },
        "excess": {
            "Common": [
                "Damage Vaccine Omega MAX"
            ]
        }
    },
    "Legend Of Blue Eyes White Dragon": {
        "_comment": "Tyhone #2 is listed as having the set codes LOB-063, LOB-EN063 and LOB-E051 which is not correct. That set code is for the first Tyhone.",
        "missing": {},
        "excess": {
            "Common": [
                "Tyhone #2"
            ]
        }
    },
    "Lightning Overdrive": {
        "missing": {},
        "excess": {
            "Common": [
                "Garden Rose Flora",
                "ZW - Dragonic Halberd"
            ]
        }
    },
    "Magician'S Force": {
        "_comment": "Luster Dragon #2 is neither in MFC nor has he an ultra printing. His incorrect set code is MFC-058 which is the first Luster Dragon as a Ultra Rare",
        "missing": {},
        "excess": {
            "Ultra Rare": [
                "Luster Dragon #2"
            ]
        }
    },
    "Metal Raiders": {
        "missing": {
            "Super Rare": [
                "Tribute to The Doomed"
            ]
        },
        "excess": {
            "Super Rare": [
                "Tribute to the Doomed"
            ]
        }
    },
    "Pharaoh'S Servant": {
        "missing": {
            "Common": [
                "Gift of The Mystical Elf"
            ]
        },
        "excess": {
            "Common": [
                "Gift of the Mystical Elf"
            ]
        }
    },
    "Rise Of The Duelist": {
        "missing": {
            "Super Rare": [
                "Soldier Gaia the Fierce Knight"
            ]
        },
        "excess": {
            "Super Rare": [
                "Soldier Gaia The Fierce Knight"
            ]
        }
    },
    "Shadow Specters": {
        "_comment": "\u00f1 is an ñ",
        "missing": {
            "Super Rare": [
                "Mari\u00f1a, Princess of Sunflowers"
            ]
        },
        "excess": {
            "Super Rare": [
                "Marina, Princess of Sunflowers"
            ]
        }
    },
    "Strike Of Neos": {
        "_comment": "\u00fa is a ú",
        "missing": {
            "Common": [
                "C\u00fa Chulainn the Awakened"
            ]
        },
        "excess": {
            "Common": [
                "Cu Chulainn the Awakened"
            ]
        }
    },
    "The Duelist Genesis": {
        "missing": {
            "Secret Rare": [
                "Fiendish Engine \u03a9"
            ]
        },
        "excess": {
            "Secret Rare": [
                "Fiendish Engine Omega"
            ]
        }
    }
}
AlanOC91 commented 3 years ago
Larikk commented 3 years ago

I reran my script today. Most of the stuff is fixed now so thank you for that 👍

I think you missed to update "ZW - Dragonic Halberd" from Lightning Overdrive; It has only a Super Rare printing but the API lists Common and Super Rare. https://db.ygoprodeck.com/api/v7/cardinfo.php?fname=Dragonic%20Halberd

I noticed two new things though that were not there yesterday: Crawling Dragon 2 and Sasuke Samurai 4 have the releases of their first counterpart listed I think. I can't check that in detail right now but will do so later and post a comment. https://db.ygoprodeck.com/api/v7/cardinfo.php?fname=Crawling%20Dragon https://db.ygoprodeck.com/api/v7/cardinfo.php?fname=Sasuke%20Samurai

I will ignore minor capitalization stuff from now on. Should I keep reporting alternative characters or ignore that too? Like I said, it does not really impact me and I just wanted to let you know.

Larikk commented 3 years ago

Crawling Dragon 2: The three entries for Metal Raiders with code 012 are incorrect, that is the first Crawling Dragon. His other printings are correct.

Sasuke Samurais:

Sasuke Samurai 1 DB2-EN216 Rare LCJW-EN034 Common PGD-015 Super Rare SBTK-EN015 Common 5DS2-EN010 Common

Sasuke Samurai 2 DCR-059 Common DCR-EN059 Common DR1-EN221 Common

Sasuke Samurai 3 DR2-EN011 Common IOC-011 Rare IOC-EN011 Rare

Sasuke Samurai 4 ~DB2-EN216 Rare~ DR3-EN076 Rare ~LCJW-EN034 Common~ ~PGD-015 Super Rare~ RDS-EN016 Rare RDS-EN016 Ultimate Rare ~SBTK-EN015 Common~ ~5DS2-En010 Common~

4 has all the releases of 1. His releases in DR3 and RDS are correct. The other Sasuke Samurais do not have that issue.

AlanOC91 commented 2 years ago

Fixed the following:

With regards to alternative characters, ignore for now. I will think on it and open a new issue to handle all of them in the coming days.

Larikk commented 2 years ago

Looks good, I dont see any issues with core sets anymore.