Alanaktion / phproject

A high performance full-featured project management system
https://www.phproject.org
GNU General Public License v3.0
384 stars 106 forks source link

IMAP configuration #377

Closed Backpackstudio closed 5 years ago

Backpackstudio commented 5 years ago

IMAP configuration page doesn't come with clear information how to properly setup IMAP connection. IP address or server name isn't enough.

If you enter just a server name, for example 'mail.myserver.com', checkmail script will fail. Instead something like this should be entered:

{mail.myserver.com:993/imap/ssl/novalidate-cert}INBOX

But sadly, thats not anywhere explained and there is no backend tests either to be sure that entered data is valid.

Alanaktion commented 5 years ago

I've added a link to the PHP documentation and changed the field to be called "Mailbox" in bdf60060077be1c56ef6d3f97b060eade63a2da8. Long-term it needs more detail, but this should be helpful enough for now, as it is a somewhat advanced feature.

The new translatable "Mailbox" string and the text below the input are also added to the translations on Crowdin

Backpackstudio commented 5 years ago

Great!

I will post today late some modificarions, which I added on checkmail2.php. These mods are log related mostly, but some other improvements too.

I noticed you are using a lot “ for strings, where shoukd be used ‘ instead, Please note If you use “, then PHP parses string, otherwise not. If parsing of string is not especially needed, “ should be avoided and ‘ used.