search

AlariCode / nestjs-rmq

A custom library for NestJS microservice. It allows you to use RabbitMQ or AMQP.
https://purpleschool.ru
MIT License
285 stars 38 forks source link

Support for amqps protocol #38

Closed gCardinal closed 2 years ago

gCardinal commented 3 years ago

As it stands, it doesn't seem like it's possible to connected with the amqps protocol when using this library. Is this correct and if so, is this a feature this library would be interested in supporting?

AlariCode commented 3 years ago

Actually, I was not tested it with amqp, but it uses amqplib under the hood: http://www.squaremobius.net/amqp.node/ It supports AMQP 0-9-1.

gCardinal commented 3 years ago

Actually, I was not tested it with amqp

I mention amqp, but I'm using RabbitMQ. They just share the same protocol, unless I'm missing something very obvious; the current project I'm working on is the first time I play around with RabbitMQ.

But anyway, what I mean, specifically, is when the service builds the connection URLs, amqp is the only protocol considered. See this line, specifically.

AlariCode commented 3 years ago

I got it, you mean hard coded ‘amqp’ protocol. You are right, there is a possibility, to connect with amqps. This will be a good improvement, and we need to support TLS certificates.

Would you like to do PR, or I can add it later this week?

AlariCode commented 2 years ago

@gCardinal added support for TLS/SSL in version 2.4.0. Now you can use amqps protocol.