search

Alarm-Siren / arduino-kicad-library

KiCad Symbol & Footprint Library for Arduino Modules (Shields, Sockets and Tiles)
Creative Commons Attribution Share Alike 4.0 International
351 stars 105 forks source link

Add Support for Arduino Nano ESP32-S3 #98

Closed SnappierSoap318 closed 11 months ago

Alarm-Siren commented 11 months ago

Hi @SnappierSoap318, thank you for submitting this.

Are you able to point me to a datasheet or, really, any documentation at all about this module? I cannot find it on Arduino's website, and my Google-fu only returns results for the normal Nano ESP32.

SnappierSoap318 commented 11 months ago

Datasheet:- https://docs.arduino.cc/resources/datasheets/ABX00083-datasheet.pdf Schematic:- https://docs.arduino.cc/resources/schematics/ABX00083-schematics.pdf

Site:- https://store.arduino.cc/products/nano-esp32 Google search gives the normal esp-32 probably because its a revision of some sort.

Alarm-Siren commented 11 months ago

I think there must be some confusion here...

The Arduino Nano ESP32 module to which you've linked was already added in release 4.2.0 of this library (see #92). The footprints and symbols you've added are identical to the existing ones except that the 5V pin has been changed to VBUS. As far as I can tell, there's no such thing as an Arduino Nano ESP32-S3. "ESP32-S3" is the name of the SoC on the module, and "Arduino Nano ESP32" is the name of the module itself.

Based on the aforementioned, I am going to decline this pull request as I believe it is a duplicate of a module that already exists in the library. If you think that the existing ESP32 module in the library should have the 5V pin changed to VBUS, please raise a seperate bug report with justification and we can discuss it :)