AlaskaAirlines / AuroDesignTokens

Abstract UI atomic values to support the Auro Design System.
https://auro.alaskaair.com/getting-started/developers/design-tokens
Apache License 2.0
19 stars 7 forks source link

Update to support darkmode #105

Closed blackfalcon closed 1 year ago

blackfalcon commented 1 year ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #102 #98

Once released, the following PR needs to be approved and shipped https://github.com/AlaskaAirlines/AuroDocsSite/pull/145

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

This PR will deprecate legacy named tokens, e.g. onLight and onDark and replace them with the new naming convention of default and inverse.

This naming is designed to move away from onDark and not confuse this with dark mode color support.

Changes to be committed: modified: src/color/alert.json modified: src/color/border.json modified: src/color/icon.json modified: src/color/text.json modified: src/color/tier.json modified: src/color/ui.json

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

blackfalcon commented 1 year ago

This PR continues to fail. I reverted the merge and will be addressing the tokens updates here https://github.com/AlaskaAirlines/AuroDesignTokens/pull/116

The other infrastructure updates will be addressed in another PR post the release of these updates.