AlaskaAirlines / AuroDocsSite

Repository for the management of the Auro doc site
https://auro.alaskaair.com/
0 stars 0 forks source link

fix(content): process page that don't include auro in the route #200 #201

Closed jason-capsule42 closed 9 months ago

jason-capsule42 commented 9 months ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes: #200

Summary:

Fix a couple broken MD pages due to props not being set and used correctly due to function calls in an if statement that kept them from running on pages where the route didn't include auro.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

blackfalcon commented 9 months ago

When I pull this branch locally and build, I am not seeing the errors corrected when clicking on the install link from Tokens. And a new bug appears that the content is just displaying code in the UI. See screenshot.

Screen Shot 2024-02-28 at 11 03 11 AM
jason-capsule42 commented 9 months ago
Screenshot 2024-02-28 at 11 22 52 AM

This renders just fine for me. Please make sure you have done a clean install of the dependencies and fully restarted the server.

The error you are showing to me looks like you are still running the old code.