AlaskaAirlines / AuroDocsSite

Repository for the management of the Auro doc site
https://auro.alaskaair.com/
0 stars 0 forks source link

Hidden overflow example is not working as expected #217

Closed jordanjones243 closed 7 months ago

jordanjones243 commented 8 months ago

Describe the bug

On the docsite, we use an example where auro-select is embedded within an auro-dialog. In this example, we have

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://auro.alaskaair.com/components/auro/select/api
  2. Scroll down to "The auro-select nested inside an auro-dialog example"
  3. Click on "Hidden Overflow Dialog" button
  4. Click on the auro-select element
  5. See error

Expected behavior

The auro-select dropdown should not exceed the border of the auro-dialog

Screenshots

Screen Shot 2024-04-01 at 11 32 58 AM

Desktop (please complete the following information):

blackfalcon commented 8 months ago

Looking at this a little more, what I didn't understand in the initial discussion was that this is simply a demonstration of potential use, not a viable part of the API.

I cannot determine when this may have stopped working, but since there is no callout from users of this not working, I recommend that we simply remove this demo from the site.

blackfalcon commented 7 months ago

Was released with this commit https://github.com/AlaskaAirlines/auro-select/commit/df9cbaece8842ddb0f252ba109d20d467e7d2bb0

There was no SEMVER release with this doc update. Subsequent feature updates are in the pipeline where this document update will get carried forward with a SEMVER release to be updated on the doc site.