Closed jason-capsule42 closed 1 month ago
This PR fixes broken dynamic link generation across multiple components by modifying the link renderer function. The changes include adding fallback text for links and correcting the href property access for external links.
classDiagram
class MarkdownPageWrapper {
+Renderer renderer
}
class Renderer {
+link(href, title, text)
}
MarkdownPageWrapper --> Renderer
note for Renderer "Updated link function to fix dynamic link generation"
class AuroComponent {
+Renderer renderer
}
class AuroContributing {
+Renderer renderer
}
class AuroTokenList {
+Renderer renderer
}
class RenderMarkdownPage {
+Renderer renderer
}
MarkdownPageWrapper <|-- AuroComponent
MarkdownPageWrapper <|-- AuroContributing
MarkdownPageWrapper <|-- AuroTokenList
MarkdownPageWrapper <|-- RenderMarkdownPage
note for AuroComponent "Uses updated renderer"
note for AuroContributing "Uses updated renderer"
note for AuroTokenList "Uses updated renderer"
note for RenderMarkdownPage "Uses updated renderer"
Change | Details | Files |
---|---|---|
Modified link renderer function to handle link text fallback |
|
src/content/dynamic/_template/component.js src/content/dynamic/contributing/contributing.js src/content/dynamic/contributing/dod.js src/content/dynamic/tokenlist/component.js src/functions/renderMarkdownPage.js |
Fixed external link href property access |
|
src/content/dynamic/_template/component.js src/content/dynamic/contributing/contributing.js src/content/dynamic/contributing/dod.js src/content/dynamic/tokenlist/component.js src/functions/renderMarkdownPage.js |
Alaska Airlines Pull Request
Summary:
fixes the broken dynamic links on several pages
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Bug Fixes: