AlaskaAirlines / AuroSvelteDemo

1 stars 2 forks source link

Jbaker/update demo components/#12 #14

Closed jason-capsule42 closed 3 years ago

jason-capsule42 commented 3 years ago

Alaska Airlines Pull Request

Resolves: #12

Summary:

Add documentation around custom element best practices.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

geoffrich commented 3 years ago

I pushed a commit making the code more Svelte-idiomatic. @jason-capsule42 let me know if you have questions about any of my changes.

blackfalcon commented 3 years ago

@geoffrich is doing a great job with this review. Carry on!

jason-capsule42 commented 3 years ago

@geoffrich I finished updates based on your initial review comments. If you could take a final pass on this so we can get it out the door that would be rad.

AuroDesignSystem commented 3 years ago

:tada: This PR is included in version 2.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: