Open blackfalcon opened 2 years ago
The content marketing team already houses the logos and manages adding new partners. Lets let them do both the logo and the tail and get our team off the hook of maintaining this.
I see that this is queued up for Sprint 14. Is it that critical to prioritize this soon? Also, is there a plan as to where to move the tail icons? I wouldn't really consider this ready to work
since there is no actual plan or exit criteria in this issue?
Keep in mind, that when we move these tails away from this repo, we will need to update auro-icon
to remove the category="logos"
property.
I am seeing that this issue has some weight on the conversation.
After discussion with multiple stakeholders, there is the desired direction for splitting Auro icons into two separate repos. All icons specifically will stay in this repo. All logos and tails will be moved to another repo.
This update will have an impact on the auro-icon
element, see this issue
The content marketing team already houses the logos and manages adding new partners. Lets let them do both the logo and the tail and get our team off the hook of maintaining this.
I am unsure how content marketing is housing the logos and tails. From what I understand, many parts of the business are referring to this repo one way or another.
I also recently learned that there is a pipeline that moves the icons and tails to an Azure blob for use.
Steps to address this update:
@aurodesignsystem/icons
In a conversation with @aesthetiques the following has been confirmed.
The Flight team is bringing in plane tails from either their own CDN or a custom component called <airline-helper>
.
The assumed impact would be to update <airline-helper>
to have a different end-point. The CDN would dump the SVGs from both the proposed Icons and Logos repos into a single bucket. This shouldn't break any references.
And even the <airline-helper>
is referencing logos from a custom CDN
https://github.com/Alaska-ECommerce/ComponentLibrary/blob/28d1677c5e1feef12bfc1a76306b56faf8011584/components/shared/buildIcon.js#L4
Problem
This icons repo was asked to take on support of tails and logos when there was no better option. As a performance issue, we should remove these logos from this repo and repurpose them elsewhere.
Proposal
Please review the following steps:
@aurodesignsystem/logos
<auro-icon>
to support both icons and logos repo endpoints https://github.com/AlaskaAirlines/auro-icon/issues/111@aurodesignsystem/icons