AlaskaAirlines / Icons

Custom HTML element for inputting string data in forms
https://auro.alaskaair.com/icons/usage
Apache License 2.0
4 stars 9 forks source link

perf: update SVGs to support new token name spec #211 #216

Closed blackfalcon closed 1 year ago

blackfalcon commented 1 year ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes: #211

Summary:

This commit reverts the revert for using the new Auro design token name spec. The revert happened due to a side-effect with auro-icon and the customSize feature. The auro-icon element was updated to allow for more flexibility in token use.

See https://github.com/AlaskaAirlines/auro-icon/pull/95

This update has been verified that regardless of version of tokens a consumer has installed, or none at all, the customSize feature will work as expected.

Changes to be committed: modified: src/data/icons.json

Type of change:

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

AuroDesignSystem commented 1 year ago

:tada: This PR is included in version 4.29.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: