AlaskaAirlines / WebCoreStyleSheets

The core front-end framework for building experiences with the Orion Design System and transition to the Auro Design System.
https://auro.alaskaair.com/webcorestylesheets
Apache License 2.0
5 stars 5 forks source link

Update to Dart Sass #103

Closed blackfalcon closed 3 years ago

blackfalcon commented 3 years ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes: #47

Summary:

A bug was reported about a peer dependency on node-sass. To best address this, the repo was updated to use Dart Sass as the primary Sass runner for the repo.

The breakpoints file needed to be updated to due to dart sass spec

node-sass is still installed due to a dependency with sass lint, the only way to address that is to update sass lint to the next major version and that requires code changes that will be way out of scope for this PR.

There are also commits for updating the npm script naming convention to be inline with common standards with Auro repos. Last there is a commit to update package dependencies and remove lit-element as a dev dependency ¯_(ツ)_/¯

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team