marnel-mangrubang commented 1 year ago

Alaska Airlines Pull Request

This PR is to address the AuroDocSite failing to build with the use of version 4.3.0 of WCSS. Due to the addition of numbers in the $auro-spacing-options default value, the auro_capitalize function inside of utilityFunctions would throw an error because its always expecting the argument type to be string. This PR is to unblock another story on our board relating to the AuroDocSite repo.

Fixes: #148

Summary:

Adding a type check inside of auro_capitalize function to only capitalize if string type. If number type, return string version of that number without capitalizing.
Update third argument of auro_map-deep-get to always be string so that it can find the value of the matching string key from the collection of tokens.
Added additional tests to spacing.spec to account for number values.

Type of change:

Please delete options that are not relevant.

[ ] New capability
[X] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[X] My update follows the CONTRIBUTING guidelines of this project
[X] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team