AlaskaAirlines / WebCoreStyleSheets

The core front-end framework for building experiences with the Orion Design System and transition to the Auro Design System.
https://auro.alaskaair.com/webcorestylesheets
Apache License 2.0
5 stars 5 forks source link

focus-visible working incorrectly #182

Closed blackfalcon closed 6 months ago

blackfalcon commented 8 months ago

Please verify the version of auro-wcss you have installed

@latest

Please describe the bug

The following code is no longer working as intended.

https://github.com/AlaskaAirlines/WebCoreStyleSheets/blob/501260243dcf24ec6b9ae96de120cbf3ae6853b1/src/_core.scss#L44-L72

This implementation had a dependency on focus-visible polyfill use and that has caused some confusion. The result is that UIs exclusively using Auro WCSS are NOT seeing focus halos when tabbing through experiences.

This use case covers everything OTHER than Auro custom elements with independent focus-visible solutions.

Reproducing the error

This issue is reproducible on the Auro docsite

Expected behavior

As a user tabs through all interactive elements of the UI there should be minimal UI feedback.

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

Additional context

No response

Exit criteria

This issue can be closed once there is new code that supports the focus-visible CSS specification.