blackfalcon
commented
5 months ago It has been determined by @leeejune that the following breakpoints are deprecated and should be removed from the project.
- ds-breakpoint-desktopLg
- ds-breakpoint-desktop
- ds-breakpoint-tabletLg
- ds-breakpoint-tablet
- ds-breakpoint-mobile
It is also noted that the breakpoints as defined in WCSS do NOT have supporting tokens and if used they will fail to build the Sass. It is safe to say that these breakpoint definitions are unknown to the public and can be safely removed from the WCSS project.
I am transferring this issue to WCSS for the removal of these mixins.
Please verify the version of Auro design tokens you have installed
@latest
Please describe the bug
See this code - https://github.com/AlaskaAirlines/WebCoreStyleSheets/pull/153/files#diff-0c8f8f9c0b9cd25cedcaace73636c77300422dfc0749b79802dedc3ac43777bb
The added references do not exit in this code
https://github.com/AlaskaAirlines/AuroDesignTokens/blob/03a51144a4d9e9cb5f4c1eb30dfa1273127a4eee/src/breakpoint.json#L1-L28
Reproducing the error
This issue cannot be reproduced on the Auro docsite
Expected behavior
The new mixins added to WCSS should have the following tokens added to the project;
ds-breakpoint-desktopLgds-breakpoint-desktopds-breakpoint-tabletLgds-breakpoint-tabletds-breakpoint-mobileWhat browsers are you seeing the problem on?
Firefox, Chrome, Safari, Microsoft Edge
Additional context
I am actually confused if these values should be added or the mixins referencing them removed. The work was to update mixins to support new tokens that were already added, but the ones in question were not part of that update.
Exit criteria
If it is decided to remove the new mixins, then this issue needs to be transferred to WCSS for the PR.
This issue can be closed once either the needed tokens are added or the mixins are deleted.