AlaskaAirlines / WebCoreStyleSheets

The core front-end framework for building experiences with the Orion Design System and transition to the Auro Design System.
https://auro.alaskaair.com/webcorestylesheets
Apache License 2.0
5 stars 5 forks source link

Dsande/remove refs/193 #194

Closed blackfalcon closed 5 months ago

blackfalcon commented 5 months ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #193

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

This update removes mixins that relied on design tokens not properly supported as Sass variables.

This change is not considered breaking since there were no tests for these mixins, and they lacked the necessary variables. Consequently, using these mixins in the public space would result in Sass compilation errors due to missing variables.

Removing this code rectifies an issue where unsupported code was added, contrary to Auro design guidelines.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

blackfalcon commented 5 months ago

:tada: This PR is included in version 5.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: