Padding exists when there is no heading content

AlaskaAirlines / auro-accordion

Custom element that allows users to toggle the display for sections of content

https://auro.alaskaair.com/components/auro/accordion

Apache License 2.0

1 stars 1 forks source link

Padding exists when there is no heading content #23

Closed gusnaughton closed 2 years ago

gusnaughton commented 3 years ago

Describe the bug

When using JUST a trigger and no header, there is 16-24px of padding added. We are expecting no padding when no content is added.

Screenshots

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context

Add any other context about the problem here.

blackfalcon commented 3 years ago

@gusnaughton I need more context for this. Can you include the code you are trying to use and a screenshot of the undesired output.

blackfalcon commented 3 years ago

I'd argue that this is not a bug, but an unexplored feature. The design intent of the accordion is to always have context for the unfolded content.

If there is no header, what is the context of the hidden content.

Please provide examples of the design intent and the please provide the name of the designer so that we can follow up on this.

blackfalcon commented 2 years ago

I am going to loop this in with the thought of redefining how this element works.

Bolting on new features to address small updates is a slippery slope. What I really see here is a request to redefine the scope of the element to allow for more flexibility in trigger and customization of UI without having the element to directly support all these minor one-offs.