AlaskaAirlines / auro-accordion

Custom element that allows users to toggle the display for sections of content
https://auro.alaskaair.com/components/auro/accordion
Apache License 2.0
1 stars 1 forks source link

auro-accordion: z-index cannot transcend the shadow-root #39

Closed gusnaughton closed 2 years ago

gusnaughton commented 2 years ago

Describe the bug

When putting our planbook component in the auro-accordion content slot, the z-index is not respected and the content which should pop out instead scrolls the entire slot down.

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

Expected: image This was generated with:

      <auro-accordion noProfile="true" chromeless="true" justifyLeft>
        <span class="accordion-text" slot="trigger">Change your search</span>

      </auro-accordion>
      <div class="planbook">
        <Planbook on:planbookSubmit={(evt) => handleMessage(evt)}></Planbook>
      </div>

Actual:

image This was generated with:

      <auro-accordion noProfile="true" chromeless="true" justifyLeft>
        <span class="accordion-text" slot="trigger">Change your search</span>
      <div class="planbook">
        <Planbook on:planbookSubmit={(evt) => handleMessage(evt)}></Planbook>
      </div>
      </auro-accordion>

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context

Add any other context about the problem here.

blackfalcon commented 2 years ago

Can you include a test URL and a video of the issue? These issues are really difficult to troubleshoot via a screenshot.

gusnaughton commented 2 years ago

Test URL: www.alaskaair.com/search/hnl/bos/29nov

Video:

https://user-images.githubusercontent.com/7005799/141532539-403974d4-1213-499f-bae5-51862c2091f0.mov

blackfalcon commented 2 years ago

Is this not the same issue that was addressed with this update? https://github.com/AlaskaAirlines/auro-accordion/pull/33/files#diff-b18ccd15ec95e2a9c4fead5bca9085042af688361a24d3463c27138e3c797a5bR32

aesthetiques commented 2 years ago

Hey Dale, I found that unless the image overflow is set to visible, it doesn't actually resolve the issue. Additionally, there are some compatibility issues with svelte and custom element properties that aren't reflected, we should probably make sure to reflect properties on our components., so that we don't have to take extra steps as a consumer. (Geoff wrote a nice article on this https://css-tricks.com/using-custom-elements-in-svelte/) Should I go ahead and draft a PR?