AlaskaAirlines / auro-accordion

Custom element that allows users to toggle the display for sections of content
https://auro.alaskaair.com/components/auro/accordion
Apache License 2.0
1 stars 2 forks source link

fix(a11y): reset height for reduced motion #42 #43

Closed geoffrich closed 2 years ago

geoffrich commented 2 years ago

Alaska Airlines Pull Request

Fixes #42

Summary:

Update WCSS dependency with changes from https://github.com/AlaskaAirlines/WebCoreStyleSheets/pull/111. This correctly resets the accordion height on open/close when reduced motion is turned on.

I made the commit type "fix" instead of "chore" because the dependency update is fixing a real issue, and wanted to trigger a release.

@blackfalcon updating the dep also updated the package lock. Since I'm on the latest npm, it also updated the lockfile format to be v2 which changed 20k+ lines. Is that okay, or do you want me to handle it differently?

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

AuroDesignSystem commented 2 years ago

:tada: This PR is included in version 1.5.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: