search

AlaskaAirlines / auro-accordion

Custom element that allows users to toggle the display for sections of content
https://auro.alaskaair.com/components/auro/accordion
Apache License 2.0
1 stars 2 forks source link

Add support to customize content area #48

Closed blackfalcon closed 2 years ago

blackfalcon commented 2 years ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #46

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Multiple PRs have been created (#33,#40) to help support custom content. The issue remains that this issue is too difficult to manage this way and a third issue was created to support the exact same scenario.

As the maintainer of a design system, trying to support all styles of content is not possible. We can do our best to support use cases that we are aware of, but in the case where the content does not fit the model we support, we must allow our users a way to customize per their content, and that is the role of CSS Parts.

Additionally, noanimation and showOverflow have been marked as deprecated as the users who requested these features will no longer be using them and I see no reason to support them.

Lastly, shade has also been marked as deprecated as this is a version of the accordion that is not in use and was never added as an official concept to the design artifacts.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

AuroDesignSystem commented 2 years ago

:tada: This PR is included in version 1.6.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: