AlaskaAirlines / auro-accordion

Custom element that allows users to toggle the display for sections of content

https://auro.alaskaair.com/components/auro/accordion

Apache License 2.0

1 stars 1 forks source link

Jbaker/new accordion #77

Closed jason-capsule42 closed 1 year ago

jason-capsule42 commented 1 year ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes: #28

Summary:

Complete rebuild of the auro-accordian using the latest version of the generator.

Type of change:

Please delete options that are not relevant.

[x] New capability
[x] Revision of an existing capability
[x] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

jordanjones243 commented 1 year ago

I am getting this error when running a build

blackfalcon commented 1 year ago

@jason-capsule42 I see this when I run a build locally?

src/style.scss
 1:1  ✖  Unknown word  CssSyntaxError

1 problem (1 error, 0 warnings)

ERROR: "scssLint" exited with 2.

jason-capsule42 commented 1 year ago

@jason-capsule42 I see this when I run a build locally?
src/style.scss
 1:1  ✖  Unknown word  CssSyntaxError

1 problem (1 error, 0 warnings)

ERROR: "scssLint" exited with 2.

This has been resolved.

jason-capsule42 commented 1 year ago

I am getting this error when running a build

This has been resolved.

github-actions[bot] commented 1 year ago

Surge demo deployment succeeded! 🚀🚀🚀

Auro Web Component Generator

blackfalcon commented 1 year ago

Surge demo deployment succeeded! 🚀🚀🚀

Auro Web Component Generator

@Izook there is an issue with the deployed demo? In the browser I see the following error

Uncaught ReferenceError: initaccordionIndexExamples is not defined
    at (index):50:7

Also, why does the link for the demo say Auro Web Component Generator, can we change that?

Assuming that none of this has anything to do with this repo and we should make an issue in the generator?

Izook commented 1 year ago

Surge demo deployment succeeded! 🚀🚀🚀 Auro Web Component Generator

@Izook there is an issue with the deployed demo? In the browser I see the following error
Uncaught ReferenceError: initaccordionIndexExamples is not defined
    at (index):50:7
Also, why does the link for the demo say Auro Web Component Generator, can we change that?

Assuming that none of this has anything to do with this repo and we should make an issue in the generator?

@blackfalcon The Uncaught ReferenceError I should be able to fix. The Auro Web Component Generator does come from the title tag in the index.html demo file. I can update it here to say something else but it would also make sense to change to say something else in the generator so we can have a consistent message in all our demos.

jason-capsule42 commented 1 year ago

Other issues found: *npmignore and gitignore files were not updated

stylelintrc was not updated

autoAssign workflow file was not added

Resolved