Closed jordanjones243 closed 10 months ago
Surge demo deployment succeeded! ššš
Surge demo deployment failed! š
This failed because the location of the resource was moved in this commit
See issue
@jordanjones243 Please update all relevant commits with the issue ID the commit is addressing.
@jordanjones243 why is the previous chore release commit rebased into this feature branch? We can't merge that into main
that way.
Noticed something else while reviewing the UI. You have a border that is applied on focus but it's only there on focus. This causes a small layout shift on focus. You should have a transparent border on the element 100% of the time and just change it to blue when focus occurs. This will prevent the layout shift.
Additionally, if I click the chevron portion of the trigger the focus border becomes persistent on the trigger. If I click the text portion of the trigger the focus border does not appear. I don't think clicking should apply the border in either case.
Resolved.
@jordanjones243 looking at this PR I also noticed that the .npmignore file is not configured correctly. It is still using the legacy version. Please review the generator for the correct configuration.
@jordanjones243 looking at this PR I also noticed that the .npmignore file is not configured correctly. It is still using the legacy version. Please review the generator for the correct configuration.
Resolved.
:tada: This PR is included in version 3.0.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #85, #86
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team