search

AlaskaAirlines / auro-accordion

Custom element that allows users to toggle the display for sections of content
https://auro.alaskaair.com/components/auro/accordion
Apache License 2.0
1 stars 1 forks source link

Re-do SSR support #94

Closed jordanjones243 closed 7 months ago

jordanjones243 commented 7 months ago

Please verify the version of auro-accordion you have installed

3.1.5

Please describe the bug

  1. Go to https://github.com/AlaskaAirlines/auro-accordion/blob/main/package.json
  2. Scroll to lines 138, 139, 150-152
  3. See incorrect paths for script files

Reproducing the error on the docsite

This issue cannot be reproduced on the Auro docsite

Expected behavior

We have the correct paths on script files

What browsers are you seeing the problem on?

Chrome

Additional context

This issue came from trial and error of our SSR updates.

This was the original PR: https://github.com/AlaskaAirlines/auro-accordion/pull/92/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

Correct work from another PR: https://github.com/AlaskaAirlines/auro-background/pull/24/commits/4cba1d7a00df9f665475b1dddb2fe7f2c6b970dc

Exit criteria

The package.json uses the correct paths to Auro script files for the component's npm scripts

jordanjones243 commented 7 months ago

This ticket is a duplicate and is not needed as the work has already been complete.