search

AlaskaAirlines / auro-alert

Custom element that renders errors, warnings, and other inline notifications with automated styling elements
https://auro.alaskaair.com/components/auro/alert
Apache License 2.0
0 stars 1 forks source link

auro-alerts: Initial build #1

Closed tsalright closed 4 years ago

tsalright commented 4 years ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes: https://github.com/AlaskaAirlines/auro/issues/87

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

The initial build of the component.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

blackfalcon commented 4 years ago

Code looks great so far. I made some changes to the design/Sass to address some issues I saw. Will address remaining browser tests and any a11y issues.

:+1:

blackfalcon commented 4 years ago

Also, the 100% width issue was not because of the component, but the demo page that you were looking at. I removed that code and everything is as it should be.

blackfalcon commented 4 years ago

I added in the auto-generated api support, please update the code with JSDoc comments for API descriptions.

tsalright commented 4 years ago

I added in the auto-generated api support, please update the code with JSDoc comments for API descriptions.

Updated code with JSDoc and also moved the dom/svg code into render to clean up the properties documentation.

AuroDesignSystem commented 4 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: