AlaskaAirlines / auro-alert

Custom element that renders errors, warnings, and other inline notifications with automated styling elements
https://auro.alaskaair.com/components/auro/alert
Apache License 2.0
0 stars 1 forks source link

fix: remove focus-visible dependency #12

Closed geoffrich closed 3 years ago

geoffrich commented 3 years ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #11

Summary:

Removes focus-visible as a dependency of auro-alerts.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

geoffrich commented 3 years ago

Tried to follow the PR/issue labeling guidelines on this one. Let me know if I should do anything differently next time.

blackfalcon commented 3 years ago

@geoffrich this looks good, but the perf prefix will not trigger a release.

This is a bug and I am ok with treating it as so. Please update your commit from perf to fix and then we can release.

geoffrich commented 3 years ago

@blackfalcon commit has been updated

AuroDesignSystem commented 3 years ago

:tada: This PR is included in version 1.4.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: