Closed jason-capsule42 closed 3 years ago
@blackfalcon This has been updated with the generator migration and should be ready for a final review and merging.
With the migration, the new main
branch needs to be pushed to the remote repo as well. The PR should be updated to point to main
as well.
This is needed because the definitions in the settings.yml
are looking for main
not master
. That's why the tests haven't fired yet.
BREAKING CHANGE: type is now a string, boolean type definitions removed
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #17
Summary:
This change converts the component from
auro-alerts
toauro-alert
. All references throughout the component updated accordingly.Additionally, alert types are no longer separate boolean attributes but instead a single
type
string attribute.Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team