search

AlaskaAirlines / auro-alert

Custom element that renders errors, warnings, and other inline notifications with automated styling elements
https://auro.alaskaair.com/components/auro/alert
Apache License 2.0
0 stars 1 forks source link

auro-alert: padding options #28

Closed braven112 closed 1 year ago

braven112 commented 2 years ago

Is your feature request related to a problem? Please describe.

We recently created an advisory page using the auro-alert component. The padding on the alert with this much content is very tight and doesn't look as nice as the auro-alert with just a single line of text.

Current Experience

image

Describe the solution you'd like

Give the implementers more options to handle padding depending on the type of content in the alert. In this case I added 2rem

image

Describe alternatives you've considered

Do nothing

Additional context

Seems to be related to the default auro-header being nice and airy at the top but when used in this context the rest of the content feels very tight.

blackfalcon commented 1 year ago

Moving this issue to tech refinement. This could be as simple as exposing CSS parts in the API and allowing the developers to adjust this as needed.

Documentation should speak to using spacing tokens to reduce the randomness of the padding.

Overly dictating options like this in the element's API have proven to do more harm than good in the past.