AlaskaAirlines / auro-alert

Custom element that renders errors, warnings, and other inline notifications with automated styling elements
https://auro.alaskaair.com/components/auro/alert
Apache License 2.0
0 stars 1 forks source link

auro-alerts: 'fixed' feature #6

Closed blackfalcon closed 3 years ago

blackfalcon commented 3 years ago

Alaska Airlines Pull Request

This PR adds the fixed feature to the base component.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

AuroDesignSystem commented 3 years ago

While this update addresses the issue related to fixed font sizes, I am not 100% happy with the implementation. Efforts were put forward to put most of this code into a higher order component, but that needs further research.

Also, efforts were put towards making the additional CSS conditional. While there is a totally plausible solution, https://stackblitz.com/edit/j9k3ga?file=my-element.js for some reason it is not working in this context. More research needs to be done.

AuroDesignSystem commented 3 years ago

:tada: This PR is included in version 1.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: