AlaskaAirlines / auro-alert

Custom element that renders errors, warnings, and other inline notifications with automated styling elements
https://auro.alaskaair.com/components/auro/alert
Apache License 2.0
0 stars 1 forks source link

[issue summary] Auro Alert icon is not properly styled #69

Open jessieiswise opened 1 week ago

jessieiswise commented 1 week ago

Please verify the version of auro-alert you have installed

v3.0.2

Please describe the bug

1 Install auro alert 3.0.2 in a vue app 2 add Auro-alert to component 3 Observe the icon is incorrectly sized Screenshot 2024-10-10 at 10 50 32 AM

Reproducing the error

None

Expected behavior

Properly sized icon

What browsers are you seeing the problem on?

No response

Additional context

When digging into this, I found that the culprit was this css rule: Screenshot 2024-10-10 at 10 55 18 AM

Note in the Auro demo page, the css rule looks like this: Screenshot 2024-10-10 at 10 55 59 AM

If I fix the rule in the demo page so that it is actually applied, the same bug appears. I think this may be visible on the vue app due to how it is rendered

Screenshot 2024-10-10 at 10 57 28 AM Screenshot 2024-10-10 at 10 59 49 AM

blackfalcon commented 6 days ago

I came across this as well and came to a similar conclusion. Why the CSS is presenting itself this way is really weird.

Additionally, I do not understand why the customSize attribute is added to this by default. That attribute is only to be applied when a different constraint is added to the outer parent of the icon. Even with this code corrected, without a parent constraint on the size, you get the same large icon result.

Screenshot 2024-10-17 at 2 46 55 PM