auro-avatar: links - Githubissues

AlaskaAirlines / auro-avatar

Custom element for the purpose of displaying an avatar image.

https://auro.alaskaair.com/components/auro/avatar

Apache License 2.0

1 stars 0 forks source link

auro-avatar: links #17

Open braven112 opened 2 years ago

braven112 commented 2 years ago

Is your feature request related to a problem? Please describe.

Sometimes we want to have text describing the avatar shown and link the entire avatar. Like in this example: https://www.alaskaair.com/content/mileage-plan/how-to-earn-miles/airline-partners

Describe the solution you'd like

it would be nice if auro-avatar supported a way to include the description and the hyperlink

Describe alternatives you've considered

In this case the solution was to not use auro-avatar. Perhaps the auro-avatar could be wrapped in a link and a hyperlink could be added below.

Additional context

A recommended solution is needed to ensure consistency and ease of implementation.

blackfalcon commented 2 years ago

@braven112 I see in the history that you removed the not-reviewed label at the point of creating the issue? Shouldn't that be on there?

braven112 commented 2 years ago

I added not-reviewed to the RC with the intent of going over this issue along with the rest of the issues to come up with our next RC.

blackfalcon commented 2 years ago

I am confused about this issue? Does Auro Avatar not already support what you are looking for?

There is a prop for the tail and a slot for any content. See demo

<auro-avatar tail="AS">
  <span slot="display">Alaska Airlines</span>
</auro-avatar>

The issue that I see with your link is that design is not using the spec of avatar at all. This version is larger and there is a new requirement to illustrate a tail with the oneWorld logo.

They are not even using the predefined tail that is in the Auro Icons lib and are creating new custom images. That alone needs to be discussed as to why that is happening.