AlaskaAirlines / auro-avatar

Custom element for the purpose of displaying an avatar image.
https://auro.alaskaair.com/components/auro/avatar
Apache License 2.0
1 stars 0 forks source link

feat(fallback): new fallback image for invalid airport codes #21

Closed jason-capsule42 closed 2 years ago

jason-capsule42 commented 2 years ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes: #13

Summary: Adds a default fallback for invalid airport codes when they fail to return a valid image.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission! -- Auro Design System Team

jason-capsule42 commented 2 years ago

The fallback image doesn't appear to be working?

Screen Shot 2022-01-20 at 9 57 44 AM

That's very confusing because this is what I see... Screen Shot 2022-01-20 at 11 25 10 AM

@blackfalcon Do you have any additional information that might help explain why you see something different?

blackfalcon commented 2 years ago

@jason-capsule42 I will let you and @braven112 decide how you want to move forward. If you want this feature to be with this release or if you want to release now and then add the httpStatus feature later... ¯_(ツ)_/¯

I approve what has been done so far per the fallback support feature.

blackfalcon commented 2 years ago

:tada: This PR is included in version 4.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: