Closed geoffrich closed 3 years ago
@geoffrich regarding your last comment about this code:
// When hiding the Medium and Large graphic element the content // must be made 100% width :host([hideGraphicMd]) { @include auro_breakpoint--sm { .bannerWrapper { display: initial; } }
I'm not sure what you think is out of date. This code does what I expect it to per the description. Switching the display to block
overrides the inline flex-basis and the content renders full width.
@jason-capsule42 I overlooked that that container is display: flex
. In that case, we should use display: flex
instead of display: initial
. Since the initial value for the display property is inline, display: initial
is equivalent to display: inline
. From your description, it sound like you want to reset the container's display property to what it was first set to, i.e. display: flex
.
Sorry @jason-capsule42 -- I got my wires crossed here and misunderstood what you were asking.
re: my last item about the comment, I didn't quite understand the code comment and how setting the display property of the wrapper made the content 100% width. So I wasn't sure if was an outdated comment or not.
Before publishing auro-banner to the Auro Design system namespace (https://github.com/AlaskaAirlines/auro-banner/issues/10), the following styling issues should be addressed:
nth-child(2)
. Several of these rules have/* stylelint-ignore */
comments. They seem to all be setting a margin to separate flex-children, and we can likely replace them by setting a single gap on the flex container itself. https://github.com/AlaskaAirlines/auro-banner/blob/578c15504a04bed1b7da7a92847869c3da490e5c/src/style.scss#L46-L55.content
is unnecessary. We are setting padding as an inline style in the component, which overrides any class-based styles. Below is one example, though we set padding multiple times in the stylesheet. https://github.com/AlaskaAirlines/auro-banner/blob/578c15504a04bed1b7da7a92847869c3da490e5c/src/style.scss#L98-L105display: block
instead ofdisplay: initial
.initial
is equivalent toinline
for the display property. For reference https://github.com/AlaskaAirlines/auro-banner/blob/578c15504a04bed1b7da7a92847869c3da490e5c/src/style.scss#L57-L90.graphic
, which is no longer present in the template. https://github.com/AlaskaAirlines/auro-banner/blob/578c15504a04bed1b7da7a92847869c3da490e5c/src/style.scss#L41-L44