AlaskaAirlines / auro-banner

Custom element that ....
https://auro.alaskaair.com/components/auro/banner
Apache License 2.0
0 stars 0 forks source link

Pre-publish: simplify and remove deprecated styles #21

Closed geoffrich closed 3 years ago

geoffrich commented 3 years ago

Before publishing auro-banner to the Auro Design system namespace (https://github.com/AlaskaAirlines/auro-banner/issues/10), the following styling issues should be addressed:

jason-capsule42 commented 3 years ago

@geoffrich regarding your last comment about this code:

// When hiding the Medium and Large graphic element the content // must be made 100% width :host([hideGraphicMd]) { @include auro_breakpoint--sm { .bannerWrapper { display: initial; } }

I'm not sure what you think is out of date. This code does what I expect it to per the description. Switching the display to block overrides the inline flex-basis and the content renders full width.

geoffrich commented 3 years ago

@jason-capsule42 I overlooked that that container is display: flex. In that case, we should use display: flex instead of display: initial. Since the initial value for the display property is inline, display: initial is equivalent to display: inline. From your description, it sound like you want to reset the container's display property to what it was first set to, i.e. display: flex.

geoffrich commented 3 years ago

Sorry @jason-capsule42 -- I got my wires crossed here and misunderstood what you were asking.

re: my last item about the comment, I didn't quite understand the code comment and how setting the display property of the wrapper made the content 100% width. So I wasn't sure if was an outdated comment or not.