AlaskaAirlines / auro-banner

Custom element that ....
https://auro.alaskaair.com/components/auro/banner
Apache License 2.0
0 stars 0 forks source link

Pre-publish: should demo images be hosted in Test sitecore? #23

Closed geoffrich closed 3 years ago

geoffrich commented 3 years ago

Several images on the demo page are in a non-prod Sitecore environment (e.g. https://sitecore-test-single-westus2.azurewebsites.net/-/media/Images/pages/examples/oneworld-travel-bright-Horizontal-300.png). Can we count on these images always being available?

I also don't know if we can count on the example images from production Sitecore always being there, or if they could get removed at some point.

We should answer this question before publishing the component to the Auro Design System namespace (#10).

braven112 commented 3 years ago

They are probably fine but good callout, we could definitely add a folder in prod sitecore to house any images we want to use for demo pages. That would allow us to use the as.com cdn. I think that is probably the safest other than housing them locally in a folder in each repo and deploying them ourselves. Advantage there is they would be available as long as the demo page is available.

I'll add this to our current release and we can figure out how to handle this.

blackfalcon commented 3 years ago

I'd personally like to stay away from using Alaska-specific imagery. In other demos we used picsum.photos as a resource.

Picsum doesn't need to be random either, you can select specific images https://picsum.photos/images

http://auro.alaskaair.com/components/auro/carousel http://auro.alaskaair.com/components/auro/banner

geoffrich commented 3 years ago

I'd personally like to stay away from using Alaska-specific imagery. In other demos we used picsum.photos as a resource.

If we don't want to use Alaska-specific imagery, we should probably revisit the "additional examples" section of the demo page, which has a lot of it (oneworld, credit card, etc):

image

braven112 commented 3 years ago

If we were to get rid of the Alaska images we'll need a little more support from design to show examples that mimic problems this component solves for that don't use the actual image we use in prod. For example a generic Credit Card image and background images that have multiple focal points and resize in a similar way.

blackfalcon commented 3 years ago

Something that I wanted to suggest was that we break this demo page into two views. One for the primary element demo that simply showcases features. Then have another page where we showcase some Alaska branded things in use.

Also referencing http://auro.alaskaair.com/components/auro/banner, ideas like Billboard / slim / alignRight / onDark and Marquee / solid are no longer to be supported?

braven112 commented 3 years ago

Something that I wanted to suggest was that we break this demo page into two views. One for the primary element demo that simply showcases features. Then have another page where we showcase some Alaska branded things in use.

That is a great way to do it!

Also referencing http://auro.alaskaair.com/components/auro/banner, ideas like Billboard / slim / alignRight / onDark and Marquee / solid are no longer to be supported?

When we are done we should be able to accomplish the same things that those examples show, just with the updated, more flexible API.