AlaskaAirlines / auro-banner

Custom element that ....
https://auro.alaskaair.com/components/auro/banner
Apache License 2.0
0 stars 0 forks source link

refactor(ratio): make ratio reactive #40

Closed jason-capsule42 closed 3 years ago

jason-capsule42 commented 3 years ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes: #27

Summary:

This change moves the ratio calculation out of firstUpdated() and makes it reactive.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team