AlaskaAirlines / auro-banner

Custom element that ....
https://auro.alaskaair.com/components/auro/banner
Apache License 2.0
0 stars 0 forks source link

Review for refactor opportunity with styleMap() #45

Closed blackfalcon closed 1 year ago

blackfalcon commented 3 years ago

General Support Request

When running $npm run build the following error appears in the CLI

./src/auro-banner.js → dist/...
(!) Plugin minify-html-literals: splitHTMLByPlaceholder() must return same number of strings as template parts
src/auro-banner.js
created dist/ in 3s

Support request

Doing some review lead me to discover this issue https://github.com/asyncLiz/rollup-plugin-minify-html-literals/issues/1

Wondering if resolving this issue would be to convert the current method of adding dynamic styles as seen here: https://github.com/AlaskaAirlines/auro-banner/blob/99bf25cbd58635e2273eaabff3387d7594c88b07/src/auro-banner.js#L288

Top use the styleMap() method from Lit

https://lit-html.polymer-project.org/guide/template-reference#stylemap