AlaskaAirlines / auro-banner

Custom element that ....
https://auro.alaskaair.com/components/auro/banner
Apache License 2.0
0 stars 0 forks source link

Move theming support from Beta to Main #63

Closed jordanjones243 closed 1 month ago

jordanjones243 commented 3 months ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #57

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

Summary by Sourcery

Move theming support for the auro-banner component from beta to main, enabling restyling through design tokens. Refactor color tokens to align with tier 3 standards and update documentation to reflect these changes.

New Features:

Enhancements:

Documentation:

CLAassistant commented 3 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

:white_check_mark: jason-capsule42
:white_check_mark: jordanjones243
:x: semantic-release-bot
You have signed the CLA already but the status is still pending? Let us recheck it.

sourcery-ai[bot] commented 3 months ago

Reviewer's Guide by Sourcery

This pull request moves theming support from Beta to Main for the auro-banner component. The changes primarily involve refactoring color tokens with tier 3 tokens, introducing new CSS custom properties for theming, and updating the component's styling approach. The main goals appear to be improving theme customization and standardizing the use of design tokens.

File-Level Changes

Files Changes
src/style.scss
src/color.scss
src/tokens.scss
Refactored color tokens to use tier 3 tokens, removing hard-coded color values and replacing them with custom properties
src/tokens.scss Introduced new CSS custom properties for theming, allowing for easier customization of banner colors
src/auro-banner.js
src/color.scss
Updated the component's styling approach by separating color-related styles into a new file and importing them in the main component
demo/api.md
docs/partials/api.md
Added documentation for theme support, including examples of how to use the new custom properties
CHANGELOG.md
README.md
Updated version numbers and changelog to reflect the new beta release
README.md Removed outdated CSS fallback documentation

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
blackfalcon commented 1 month ago

:tada: This PR is included in version 3.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: