AlaskaAirlines / auro-carousel

Custom element that ....
https://auro.alaskaair.com/components/auro/carousel
Apache License 2.0
0 stars 4 forks source link

refactor(scss): remove references to orion #17

Closed janabimustafa closed 2 years ago

janabimustafa commented 2 years ago

Alaska Airlines Pull Request

This PR modernizes the component to remove orion references.

Summary:

With alpine deprecating the python 2.x packages, Dockerfiles with projects referencing this package will fail to build due to node-gyp dependency in this package requiring python 2. This node-gyp dependency is coming from the older orion packages required by this component.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

blackfalcon commented 2 years ago

@janabimustafa are you sure that this is just an Orion thing, or is this a node-sass/node-16 thing? Newer repos have support for dart-sass.

Node-sass is a dependency of "wc-sass-render": "^1.2.3",. The latest version supports dart-sass based on this PR https://github.com/tristanMatthias/wc-sass-render/pull/21

Updating that then requires some additional updates to the Sass imports and the npm script calls.

blackfalcon commented 2 years ago

@janabimustafa I created a new issue to address this particular problem. I will close this PR and open a new one that will address the legacy Orion references and update all the sass to use dart-sass versus node-sass.