Dependency on node-sass breaks modern builds

AlaskaAirlines / auro-carousel

Custom element that ....

https://auro.alaskaair.com/components/auro/carousel

Apache License 2.0

0 stars 4 forks source link

Dependency on node-sass breaks modern builds #18

Closed blackfalcon closed 4 months ago

blackfalcon commented 2 years ago

Describe the bug

See the following PR

https://github.com/AlaskaAirlines/auro-carousel/pull/17

The scope of this issue is to update this project to use dart-sass versus node-sass via the updated wc-sass-render package. This will allow for modern builds with node 16.

jordanchang commented 10 months ago

@aesthetiques, Is this fixed? I see the Issue #25 is closed, but this one is still open. I can now build with auro-carousel v2.0.0, but during runtime, there is a CSS error.

blackfalcon commented 9 months ago

I consulted @jordanchang via screen share and observed the error. The team was advised to revert back to v1.4.0 in order to have a stable app until the underlying issue can be resolved.

To address this, I will do a complete review of the 2.0.0 release diff and see if I can discover what the corrective action is to take. WIth a working resolution, I intend to review the update with @jordanchang project before calling this fixed.

braven112 commented 8 months ago

@blackfalcon Does this issue have to be addressed before we can complete this one? https://github.com/AlaskaAirlines/auro-carousel/issues/32

blackfalcon commented 8 months ago

@blackfalcon Does this issue have to be addressed before we can complete this one? #32

Yes

blackfalcon commented 5 months ago

This issue should be resolved. Following up with @danhiel to verify this has been addressed.