search

AlaskaAirlines / auro-carousel

Custom element that ....
https://auro.alaskaair.com/components/auro/carousel
Apache License 2.0
0 stars 4 forks source link

auro-carousel: gradient change #32

Closed leeejune closed 1 month ago

leeejune commented 9 months ago

Is your feature request related to a problem? Please describe.

When a background color that is not background-lightest is used with the carousel, the gradient shows through the background.

Describe the solution you'd like

Make the color of the gradient customizable to any color.

Describe alternatives you've considered

Make the gradient an optional property.

Additional context

See issue below.

MicrosoftTeams-image (4)

braven112 commented 9 months ago

Having it completely custom would be great, but I think we should also support a pretty simple implementation for any component that uses one of our existing bg colors as well. Having consistent gradient tokens for at least these 4 backgrounds is a must in order to fully support theming. If we only support the custom option then this would break when changing themes or require the implementer to create another custom option. image

braven112 commented 9 months ago

Ideally the component would work on any background color but a good alternative would be to support the 4 current backgrounds listed above and allow the implementer to choose what background this component is being placed on.

braven112 commented 8 months ago

The gradient solution we come up with here should also support the gradient needed in this issue: https://github.com/AlaskaAirlines/auro-datepicker/issues/150

johnalaska commented 6 months ago

I've been looking at the gradient for the Flight Search Microsite and I believe these gradients are rotated 90 degrees from what we need. The old version had left-to-right or right-to-left gradients from background color to opaque #FFF. Now we're seeing background color gradient toward transparency, but it's top-down on one side and bottom-up on the right. I set our background color to #F00 for this screenshot just so it's easier to see, there's no other change from me.

Screenshot 2024-01-12 at 9 54 56 AM

jordanjones243 commented 6 months ago

Re-opening this issue as the change previously done created a bug for the flight search team. The gradient is moving in the wrong direction.

jordanjones243 commented 6 months ago

The issue for flight-search was resolved, but the value of the token being used in this repo should probably be reviewed at a later date.