search

AlaskaAirlines / auro-checkbox

Custom element for the purpose of allowing users to select one or more options of a limited number of choices.
https://auro.alaskaair.com/components/auro/checkbox
Apache License 2.0
0 stars 1 forks source link

Update repo to support WCSS and tokens MAJOR updates #114

Closed blackfalcon closed 8 months ago

blackfalcon commented 11 months ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #113, #40

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

This commit updates to the new major releases of WCSS and auro design tokens. Due to code changes in Auro design tokens, all references to --auro were updated to --ds. Other token ref changes are due to deprecated tokens.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

github-actions[bot] commented 11 months ago

Surge demo deployment succeeded! 🚀🚀🚀

Auro Web Component Generator

blackfalcon commented 11 months ago

Need to run a build here. The api.md file should have a change because of the typos you fixed.

Build was updated and committed. FYI... this code is supposed to run the build in the remote and then commit back to the repo. I created a new issue to look into this.

https://github.com/AlaskaAirlines/auro-checkbox/blob/03777edf3c5e93246f40cc6bd32d20e69b8e628f/package.json#L110-L117

blackfalcon commented 11 months ago

This PR is blocked as the dependency on auro icons was reverted

This update will need to be re-applied and a solution shipped for auro-icon shipped as well before this can be completed.

Patrick-Daly-AA commented 9 months ago

@blackfalcon , "pick this up again and finish it"

jordanjones243 commented 8 months ago

Local host of this branch doesn't work with tabbing focus to a checkbox but it does work on the docsite.

Localhost API page examples - checkbox is being rendered on the wrong side of the element.

Screenshot 2024-01-08 at 7 48 52 PM

This issue does not occur on my localhost, we can discuss this further together if this bug still persists for you. All other issues have been addressed.

blackfalcon commented 8 months ago

:tada: This PR is included in version 2.0.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: